Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Patch locked deposits #100

Conversation

sirouk
Copy link
Contributor

@sirouk sirouk commented Nov 14, 2023

No description provided.

@sirouk sirouk changed the title Patch locked deposits [Move] Patch locked deposits Nov 14, 2023
Copy link
Contributor

@hemulin hemulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand most of the changes.

Looks okay to me.

I think that the public fun get_balance can be useful and I'm not sure why it was removed. @0o-de-lally

@0o-de-lally 0o-de-lally changed the title [Move] Patch locked deposits [move] Patch locked deposits Nov 14, 2023
@0o-de-lally
Copy link
Contributor

I think that the public fun get_balance can be useful and I'm not sure why it was removed. @0o-de-lally

There was lots of duplication (quadruplicates). I made ol_account::balance() the canonical way to get balance.

@0o-de-lally 0o-de-lally merged commit 8c77139 into 0LNetworkCommunity:release-6.9.0-rc.8 Nov 14, 2023
11 checks passed
hemulin pushed a commit that referenced this pull request Nov 14, 2023
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants