Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] change community wallet default n-of-m to reduce threshold #172

Merged
merged 5 commits into from
Feb 13, 2024

Conversation

0xzoz
Copy link
Contributor

@0xzoz 0xzoz commented Feb 12, 2024

Previous check was prohibitively restrictive due to the ancestry requirements. This fix directly rectifies the issue presented in #169 by reducing the threshold requirements from 3/5 n of m to 2/3.

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
@0xzoz 0xzoz requested review from sirouk, hemulin and codilion February 12, 2024 21:23
Copy link
Contributor

@sirouk sirouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@0xzoz 0xzoz merged commit c816401 into 0LNetworkCommunity:main Feb 13, 2024
10 of 12 checks passed
davidrotari19 pushed a commit to davidrotari19/libra-framework that referenced this pull request Feb 15, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit that referenced this pull request Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 16, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally added a commit to 0o-de-lally/libra-framework that referenced this pull request Aug 17, 2024
…etworkCommunity#172)

Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants