-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] change community wallet default n-of-m to reduce threshold #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
…check is already quite restrictive
0o-de-lally
force-pushed
the
cw-threshold
branch
from
February 12, 2024 21:56
0168c16
to
a1c0ad0
Compare
sirouk
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM!
The1OneID
reviewed
Feb 13, 2024
The1OneID
approved these changes
Feb 13, 2024
davidrotari19
pushed a commit
to davidrotari19/libra-framework
that referenced
this pull request
Feb 15, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
that referenced
this pull request
Aug 8, 2024
Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 16, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
0o-de-lally
added a commit
to 0o-de-lally/libra-framework
that referenced
this pull request
Aug 17, 2024
…etworkCommunity#172) Co-authored-by: 0o-de-lally <1364012+0o-de-lally@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous check was prohibitively restrictive due to the ancestry requirements. This fix directly rectifies the issue presented in #169 by reducing the threshold requirements from 3/5 n of m to 2/3.