[move] Remove framework bloat #205
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xzoz
approved these changes
Mar 11, 2024
0xzoz
reviewed
Mar 12, 2024
There was a problem hiding this comment.
changes to this file prevent single step upgrades to complete both vanilla and with --danger-force-upgrade
| #[test_only] | ||
| friend diem_framework::diem_account; | ||
| #[test_only] | ||
| friend diem_framework::resource_account; |
There was a problem hiding this comment.
changing this to use the test_only pragma prevented multiple step upgrades to complete both vanilla and with --danger-force-upgrade
|
closing this and reintroducing in #209 which addresses the comments and allows the framework to be upgraded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing certain modules from mainnet compile. Some modules are useful to reproduce tests, so they will be left with #[test_only] pragma.