Skip to content

Commit

Permalink
memblock-stop-using-implicit-alignement-to-smp_cache_bytes-checkpatch…
Browse files Browse the repository at this point in the history
…-fixes

ERROR: code indent should use tabs where possible
torvalds#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+        hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$

WARNING: please, no spaces at the start of a line
torvalds#244: FILE: arch/alpha/kernel/core_wildfire.c:114:
+        hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,$

ERROR: code indent should use tabs where possible
torvalds#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+        hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$

WARNING: please, no spaces at the start of a line
torvalds#246: FILE: arch/alpha/kernel/core_wildfire.c:116:
+        hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,$

ERROR: space required after that ';' (ctx:VxV)
torvalds#380: FILE: arch/ia64/kernel/mca.c:366:
+		(ia64_err_rec_t *)memblock_alloc(size, SMP_CACHE_BYTES);}
 		                                                       ^

WARNING: line over 80 characters
torvalds#822: FILE: mm/percpu.c:1104:
+	chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT),

WARNING: line over 80 characters
torvalds#837: FILE: mm/percpu.c:1116:
+	chunk->alloc_map = memblock_alloc(BITS_TO_LONGS(region_bits) * sizeof(chunk->alloc_map[0]),

WARNING: line over 80 characters
torvalds#839: FILE: mm/percpu.c:1118:
+	chunk->bound_map = memblock_alloc(BITS_TO_LONGS(region_bits + 1) * sizeof(chunk->bound_map[0]),

WARNING: line over 80 characters
torvalds#841: FILE: mm/percpu.c:1120:
+	chunk->md_blocks = memblock_alloc(pcpu_chunk_nr_blocks(chunk) * sizeof(chunk->md_blocks[0]),

total: 3 errors, 6 warnings, 618 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

NOTE: Whitespace errors detected.
      You may wish to use scripts/cleanpatch or scripts/cleanfile

./patches/memblock-stop-using-implicit-alignement-to-smp_cache_bytes.patch has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Mike Rapoport <rppt@linux.vnet.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
  • Loading branch information
akpm00 authored and sfrothwell committed Oct 16, 2018
1 parent 2df09e6 commit 5989d8e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions arch/alpha/kernel/core_wildfire.c
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,9 @@ wildfire_init_hose(int qbbno, int hoseno)
* ??? We ought to scale window 3 memory.
*
*/
hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,
hose->sg_isa = iommu_arena_new(hose, 0x00800000, 0x00800000,
SMP_CACHE_BYTES);
hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,
hose->sg_pci = iommu_arena_new(hose, 0xc0000000, 0x08000000,
SMP_CACHE_BYTES);

pci = WILDFIRE_pci(qbbno, hoseno);
Expand Down
3 changes: 2 additions & 1 deletion mm/percpu.c
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,8 @@ static struct pcpu_chunk * __init pcpu_alloc_first_chunk(unsigned long tmp_addr,
region_size = ALIGN(start_offset + map_size, lcm_align);

/* allocate chunk */
chunk = memblock_alloc(sizeof(struct pcpu_chunk) + BITS_TO_LONGS(region_size >> PAGE_SHIFT),
chunk = memblock_alloc(sizeof(struct pcpu_chunk) +
BITS_TO_LONGS(region_size >> PAGE_SHIFT),
SMP_CACHE_BYTES);

INIT_LIST_HEAD(&chunk->list);
Expand Down

0 comments on commit 5989d8e

Please sign in to comment.