refactor: Accept pre-processed schemas as introspection inputs #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9d4a4df The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Mar 20, 2024
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
kitten
force-pushed
the
refactor/split-scalars-and-introspection-mapping
branch
from
01a87ad
to
9d4a4df
Compare
Merged
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This allows the API to accept a pre-processed “
gql.tadaschema” to be accepted as theintrospectionoption (i.e. onAbstractSetupSchema/setupSchema). Effectively, this means thatmapIntrospectionis used on demand, and only when the input hasn't already been run throughmapIntrospectionbefore.This also required us to then split introspection mapping into two steps — one for the general remapping, and one for scalars.
Set of changes
mapIntrospectioninto non-scalar and scalar-adding stepsintrospectionoption