Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli-utils): Fix turbo command reusing its own prior cache output #208

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Apr 15, 2024

Summary

Fixes a regression; the turbo command can accidentally reuse its own cache if we don't disable the cache or remove the cached typings file.

Instead of removing the file or discovering and shadowing it, we now add a global flag to disable the cache entirely while inferring the turbo cache.

Set of changes

  • Add __disableCache flag to turbo cache
  • Add virtual declaration file to declare __disableCache: true during turbo command

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: f1694b7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten merged commit 251b9b0 into main Apr 15, 2024
2 checks passed
@kitten kitten deleted the fix/turbo-reevaluation branch April 15, 2024 15:39
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants