fix: Remove redundant constraints on IntrospectionQuery causing TS perf bottlenecks #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22
Summary
This removes any unnecessary and redundant constraints in
IntrospectionQuery
, which previously forced TypeScript to recursively check the inputIntrospectionQuery
data (i.e. the schema data a user gives us) against the constraint type.This meant that TypeScript was spending a lot of time in
recursiveTypeRelatedTo
, only to recursively unroll an introspection schema that we were mapping and checking anyway.Instead, this constraint is now removed and also doesn't affect code paths that run after
mapIntrospection
has run already.Set of changes
args
fromIntrospectionField
interfaces
fromIntrospectionObjectType
andIntrospectionInterfaceType
types
constraint toreadonly any[]
inIntrospectionSchema