feat(cli): add gql.tada/ts-plugin to init/doctor
#276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0379cd9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
force-pushed
the
add-to-doctor-and-init
branch
from
d732f8a
to
679f231
Compare
JoviDeCroock
force-pushed
the
add-to-doctor-and-init
branch
from
679f231
to
0379cd9
Compare
kitten
approved these changes
Apr 28, 2024
| ) | ||
| ); | ||
| const supportsEmbeddedLsp = semiverComply( | ||
| typeScriptVersion[1], |
There was a problem hiding this comment.
Since TS is now a peer dependency, we should be able to read this from require('typescript').version. Probably have to try-catch it with a new error, but that should also just give us the raw version.
There was a problem hiding this comment.
Can do that in a follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #75
Summary
This PR adds a new minimum version for TypeScript to support sub-modules in a library for the LSP Plugins.
doctorwe will check forgql.tada/ts-pluginwhen TS is > 5.5 so folks are pushed to migrateinitwe automatically addgql.tada/ts-pluginwhen TS is > 5.5