Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli-utils): Add separate support packages for Vue & Svelte #361

Merged
merged 12 commits into from
Jul 31, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 31, 2024

Resolve #288

When applied, this provides two separate support packages:

  • @gql.tada/vue-support
  • @gql.tada/svelte-support

These packages are marked as optional peer dependencies and can be installed alongside gql.tada. The CLI will dynamically load them (instead of the baked in transformers previously) to convert Vue and Svelte SFC files.

For example, given a Vue project, doctor will now raise a warning if @gql.tada/vue-support is not installed and say it must be installed. Similarly, the TypeScript transformer will raise an error for other commands for Vue files.

Given a Svelte project, doctor will now raise a warning if @gql.tada/svelte-support is not installed and say it must be installed. Similarly, the TypeScript transformer will raise an error for other commands for Svelte files.

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 975d12b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten marked this pull request as ready for review July 31, 2024 11:57
@kitten kitten requested a review from JoviDeCroock July 31, 2024 12:06
@kitten kitten merged commit 478968b into main Jul 31, 2024
2 checks passed
@kitten kitten deleted the feat/support-packages branch July 31, 2024 17:47
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Make vue and svelte dependencies optional
2 participants