Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flake8 warnings/errors #248

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix flake8 warnings/errors #248

wants to merge 2 commits into from

Conversation

chombourger
Copy link
Contributor

The following warnings/errors are reported with HEAD (99ee6e4)

zerorpc/channel.py:235:9: E722 do not use bare 'except'
zerorpc/core.py:81:54: W504 line break after binary operator
zerorpc/core.py:271:48: W504 line break after binary operator
zerorpc/core.py:272:13: E129 visually indented line with same indent as next logical line
zerorpc/events.py:70:13: F841 local variable 'e' is assigned to but never used
zerorpc/events.py:76:9: F841 local variable 'e' is assigned to but never used
zerorpc/events.py:100:13: F841 local variable 'e' is assigned to but never used

@chombourger
make flake8 ignore W503
e0ae295 
Knuth's style is preferred these days, ignore W503 and we will fix
W504 instead (flake8 --ignore=W503 --select=W504)

Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
@chombourger
fix flake8 warnings/errors
8112041 
Signed-off-by: Cedric Hombourger <cedric.hombourger@siemens.com>
@chombourger
Copy link
Contributor Author

@bombela did you have a chance to check this PR?

@chombourger chombourger mentioned this pull request May 19, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chombourger