Install zerorpc-client script in a way that is Windows-compatible. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, need to amend that commit, forgot to include everything that was needed. |
Instead of using the `scripts=[...]` argument for `setup()`, use the `console_scripts` entry point to define the same script. Setuptools takes care of creating a Windows executable wrapper around the script. On POSIX platforms, it installs the script wrapper as an executable Python script.
|
OK, the above commit has the complete set of changes I intended for this pull request. :) |
|
I tried you patch quickly, seem to work fine with distutils on linux, however, I prefer to use dict/list/types rather than an raw string to define the entry point. I will fix that after merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the
scripts=[...]argument forsetup(), use theconsole_scriptsentry point to define the same script. Setuptools takes care of creating a Windows executable wrapper around the script. On POSIX platforms, it installs the script wrapper as an executable Python script.