-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for types 8, 9 & 10 #22
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Booyah! Will look at this this week, thanks again for your hard work! Cheers |
hugsy
commented
Dec 13, 2023
Ok I did first pass, I think it's looking good. I need to do a second pass and check the misc stuff, like small documentation for the Python README and then we should be good to go! Cheers |
hugsy
commented
Dec 19, 2023
Closed
2 tasks
It's live at https://pypi.org/project/kdmp-parser/0.7.0/, thanks again! |
Thanks for the review & merge ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
Add support for dump types for modern WinDbg versions:
.dump /k
(Create a dump with kernel memory only).dump /ka
(Create a dump with active kernel and user mode memory).dump /f
(Create a full dump)Also:
FizeSize()
to the FileMapHEADER64
to Python too, as justly noted by @neitsa this simply addition is costless, but very valuable.Additional notes
__unknownXX
. However I tested against quite a number of dumps, and could validate my findings but since there's no public implementation (kdmp-parser will be the first 😉) I couldn't fact-check it otherwise;Those are GCC specific errors claiming not to be able to calculate the offset checks used in the
static_assert
. This is completely wrong, and the other compilers (CLANG/CL) don't say anything. In addition, even GCC produces the correct format so the behavior doesn't change in any way. Therefore I chose to explicitly silence it (punctually to thoseassert
checks).Happy to discuss any of those points.
Fixes #17
Fixes #18