Clean-ups from various static analysis engine. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/src/python/python-kdmp.cc b/src/python/python-kdmp.cc
index 4682b42..6444770 100644
--- a/src/python/python-kdmp.cc
+++ b/src/python/python-kdmp.cc
@@ -7,10 +7,12 @@
//
PyObject *NewDumpParser(PyTypeObject *Type, PyObject *Args, PyObject *Kwds) {
+ UNREFERENCED_PARAMETER(Kwds);
//
// Allocate and zero PythonDumpParser.
//
+
PythonDumpParser *Self =
reinterpret_cast<PythonDumpParser *>(Type->tp_alloc(Type, 0));
Self->DumpParser = nullptr;
@@ -74,6 +76,7 @@ void DeleteDumpParser(PyObject *Object) {
//
PyObject *DumpParserGetType(PyObject *Object, PyObject *NotUsed) {
+ UNREFERENCED_PARAMETER(NotUsed);
//
// Get the dump type (FullDump, KernelDump or BMPDump).
@@ -89,6 +92,7 @@ PyObject *DumpParserGetType(PyObject *Object, PyObject *NotUsed) {
//
PyObject *DumpParserGetContext(PyObject *Object, PyObject *NotUsed) {
+ UNREFERENCED_PARAMETER(NotUsed);
//
// Get the dump context (commons registers).
@@ -139,6 +143,7 @@ PyObject *DumpParserGetContext(PyObject *Object, PyObject *NotUsed) {
//
PyObject *DumpParserGetBugCheckParameters(PyObject *Object, PyObject *NotUsed) {
+ UNREFERENCED_PARAMETER(NotUsed);
//
// Retrieve the bugcheck parameters.
diff --git a/src/python/python-kdmp.cc b/src/python/python-kdmp.cc
index 6444770..55d0a92 100644
--- a/src/python/python-kdmp.cc
+++ b/src/python/python-kdmp.cc
@@ -6,8 +6,7 @@
// >>> Dump(filepath)
//
-PyObject *NewDumpParser(PyTypeObject *Type, PyObject *Args, PyObject *Kwds) {
- UNREFERENCED_PARAMETER(Kwds);
+PyObject *NewDumpParser(PyTypeObject *Type, PyObject *Args, PyObject *) {
//
// Allocate and zero PythonDumpParser.
@@ -75,8 +74,7 @@ void DeleteDumpParser(PyObject *Object) {
// >>> dump_instance.type() # return int
//
-PyObject *DumpParserGetType(PyObject *Object, PyObject *NotUsed) {
- UNREFERENCED_PARAMETER(NotUsed);
+PyObject *DumpParserGetType(PyObject *Object, PyObject *) {
//
// Get the dump type (FullDump, KernelDump or BMPDump).
@@ -91,8 +89,7 @@ PyObject *DumpParserGetType(PyObject *Object, PyObject *NotUsed) {
// >>> dump_instance.context() # return dict(str -> int)
//
-PyObject *DumpParserGetContext(PyObject *Object, PyObject *NotUsed) {
- UNREFERENCED_PARAMETER(NotUsed);
+PyObject *DumpParserGetContext(PyObject *Object, PyObject *) {
//
// Get the dump context (commons registers).
@@ -142,8 +139,7 @@ PyObject *DumpParserGetContext(PyObject *Object, PyObject *NotUsed) {
// >>> dump_instance.bugcheck() # return dict
//
-PyObject *DumpParserGetBugCheckParameters(PyObject *Object, PyObject *NotUsed) {
- UNREFERENCED_PARAMETER(NotUsed);
+PyObject *DumpParserGetBugCheckParameters(PyObject *Object, PyObject *) {
//
// Retrieve the bugcheck parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.