Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IR devices creating >100 services per accessory #239

Merged
merged 5 commits into from
May 7, 2023
Merged

Fix IR devices creating >100 services per accessory #239

merged 5 commits into from
May 7, 2023

Conversation

bimusiek
Copy link

Fixes #238

@0x5e
Copy link
Owner

0x5e commented Feb 22, 2023

Thanks for the PR! the BaseAccessory will add AccessoryInformation and Battery(not exist for IR device) services, so should it be 99 instead of 100?
I'm curious why you have so many services..

@0x5e 0x5e force-pushed the develop_1.7.0 branch 6 times, most recently from bb5584d to 29de94d Compare March 1, 2023 06:02
@0x5e 0x5e merged commit bc2f3fd into 0x5e:develop_1.7.0 May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IR Devices error out as the limit is 100 services per accessory.
2 participants
@bimusiek @0x5e