Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update config.schema.json #282

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Update config.schema.json #282

merged 2 commits into from
Apr 17, 2023

Conversation

donavanbecker
Copy link

  • Add Name config so that name is used in the logs instead of the full plugin name.
  • removed default for type on deviceoverridee as it was inputting "Boolean" every time you save config

0x5e
0x5e requested changes Apr 17, 2023
View reviewed changes
config.schema.json Outdated Show resolved Hide resolved
@0x5e
Copy link
Owner

0x5e commented Apr 17, 2023

thanks @donavanbecker , there's some issue with tab & space, others are okay :)

@0x5e
Copy link
Owner

0x5e commented Apr 17, 2023

I didn't know I can update your branch... is okay now.... thanks again!

@0x5e 0x5e merged commit 6962bf9 into 0x5e:develop_1.7.0 Apr 17, 2023
@donavanbecker
Copy link
Author

I will be posting some more changes soon :)

@donavanbecker donavanbecker deleted the patch-1 branch April 17, 2023 22:57
@donavanbecker
Copy link
Author

See #285 and #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5e 0x5e 0x5e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@donavanbecker @0x5e