Skip to content

Commit

Permalink
[youtube] Improve description extraction (closes #25937) (#25980)
Browse files Browse the repository at this point in the history 
(cherry picked from commit a115e07)
  • Loading branch information
@MRWITEK @0x9fff00
MRWITEK authored and 0x9fff00 committed Jul 14, 2020
1 parent 4c2fc4e commit 22b3d7a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion youtube_dl/extractor/youtube.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1954,7 +1954,7 @@ def replace_url(m):
''', replace_url, video_description)
video_description = clean_html(video_description)
else:
video_description = self._html_search_meta('description', video_webpage) or video_details.get('shortDescription')
video_description = video_details.get('shortDescription') or self._html_search_meta('description', video_webpage)

if not smuggled_data.get('force_singlefeed', False):
if not self._downloader.params.get('noplaylist'):
Expand Down

1 comment on commit 22b3d7a

@subirax
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why issue 25937 has been closed. The fix reported here addresses a different issue. Issue 25937 remains exactly as it was when I first reported it.

This command including write-description:

youtube-dl --restrict-filenames --write-description -o "%%(title)s.%%(ext)s" -f 140 https://www.youtube.com/watch?v=-dac_2af0Ww

...still truncates descriptions at 160 characters. This problem has not been fixed.

I've checked for ytdl updates and run exactly the same command as generated the issue.

See my original report:

ytdl-org/youtube-dl#25937 (comment)

Will this issue be re-opened, or should I start a new thread?

Thanks!

Please sign in to comment.