bugfixes and tests

0xEssential · Jul 27, 2023 · 02635cc · 02635cc
1 parent 2f3d2a6
commit 02635cc
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 1 deletion.
diff --git a/packages/ownership-oracle/__tests__/DelegationTree.test.ts b/packages/ownership-oracle/__tests__/DelegationTree.test.ts
@@ -49,6 +49,28 @@ describe('DelegationTree', () => {
       expect(authorized).toBe(false);
     });
 
+    it('returns false when signer is not owner and no authorizer', async () => {
+      getAllDelegationsMock.mockReturnValueOnce([
+        {
+          vault: owner.address,
+          tokenId,
+          contract_: nftContract,
+          delegate: signer.address,
+          type_: 1,
+        },
+      ]);
+
+      const tree = new DelegationTree(
+        provider,
+        nftContract,
+        tokenId,
+        signer.address,
+      );
+
+      const authorized = await tree.hasDelegatedOwnership('');
+      expect(authorized).toBe(false);
+    });
+
     it('returns false when authorizer is not owner', async () => {
       getAllDelegationsMock.mockReturnValueOnce([
         {

diff --git a/packages/ownership-oracle/__tests__/OwnershipService.test.ts b/packages/ownership-oracle/__tests__/OwnershipService.test.ts
@@ -65,6 +65,7 @@ describe('OwnershipService', () => {
           return owner.address;
         });
     });
+
     it('should throw an error when not authorized', async () => {
       hasDelegatedOwnershipMock.mockResolvedValue(false);
 

diff --git a/packages/ownership-oracle/__tests__/api.test.ts b/packages/ownership-oracle/__tests__/api.test.ts
@@ -56,6 +56,7 @@ describe('durin_call endpoint', () => {
     expect(response.status).toBe(200);
     expect(response.body).toHaveProperty('result', 'gud proof');
   });
+
   it('returns an error if signer is neither owner nor authorized', async () => {
     processCallMock.mockRejectedValue(new Error('bad proof'));
 

diff --git a/packages/ownership-oracle/src/NetworkProvider.ts b/packages/ownership-oracle/src/NetworkProvider.ts
@@ -7,6 +7,7 @@ export const PROVIDERS = {
   7700: 'https://canto.slingshot.finance/',
   740: 'https://eth.plexnode.wtf/',
   42170: 'https://nova.arbitrum.io/rpc',
+  7777777: 'https://rpc.zora.energy/',
 };
 
 class NetworkProvider {
@@ -22,6 +23,7 @@ class NetworkProvider {
       case 7700:
       case 740:
       case 42170:
+      case 7777777:
         provider = new providers.JsonRpcProvider(PROVIDERS[chainId], chainId);
         break;
       default:

diff --git a/packages/ownership-oracle/src/OwnershipService.ts b/packages/ownership-oracle/src/OwnershipService.ts
@@ -109,7 +109,7 @@ class OwnershipService {
       from,
     );
 
-    const authorized = await delegationTree.hasDelegatedOwnership(authorizer);
+    const authorized = await delegationTree.hasDelegatedOwnership(owner);
 
     if (authorized) {
       console.warn('AUTHORIZED RECURSIVELY');