Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

goreleaser for validium node #82

Merged

Conversation

christophercampbell
Copy link

Closes #71. Adds goreleaser to github workflow

Dockerfile.release Outdated Show resolved Hide resolved
Dockerfile.release Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated Show resolved Hide resolved
.goreleaser.yaml Outdated

dockers:
- image_templates:
- 0xpolygon/{{ .ProjectName }}:{{ .Version }}-amd64

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tweek the version here as it will try to push +cdk tags that are not compatible with docker

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcastellm would changing the +cdk to -cdk work? As in

{{ replace .Version "+" "-" }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And do all the uses of Version have to change? name_templates, image_templates, flag_templates?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm only the strings that correspond to docker tags

Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the differences are pretty clear, we should try to come up with a way to maintain this in another file than .goreleaser.yml

Ideally for me, we should try to change the way docker images are build in zkevm so we can use basically the same file.

Copy link

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to be a blocker here

@christophercampbell christophercampbell merged commit f5d2c80 into develop Feb 26, 2024
17 checks passed
@christophercampbell christophercampbell deleted the CDK-71-introduce-goreleaser-on-cdk-validum-node branch February 26, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants