-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: bridge e2e testing #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcastellm
commented
Sep 3, 2024
vcastellm
changed the title
tests: bridge testing with bats PoC
test: bridge testing with bats PoC
Sep 10, 2024
vcastellm
changed the title
test: bridge testing with bats PoC
test: bridge e2e testing
Sep 10, 2024
There's new linting errors not sure why, they should be fixed in a new PR |
Stefan-Ethernal
approved these changes
Sep 13, 2024
goran-ethernal
approved these changes
Sep 16, 2024
|
* feat: add helper functions for contract deployment and sending transactions using cast commands * feat: send EOA transaction test basic * feat: add CDK_ERIGON_NODE_NAME var * feat: invoke _common_setup function * feat: deploy ERC20Mock contract E2E test * feat: more strict assertions and use run instead of $ * feat: tweaks * fix: change the way transaction hash is extracted * fix: change the way transactionHash gets fetched from the output * fix: cast call helper function and invocation of balanceOf function * test: use RAW_PRIVATE_KEY env variable for sender private key * fix: address feedback from @vcastellm * fix: Linters warning fixes (#74) * feat: use the latest golangci-lint version and fix config warnings * fix: linter warnings * fix: linter warnings (part 2) * fix: propagate the error from aggregator.Start * fix: format golangci config file * fix: suppress gosec overflow issues * fix: exclude G115 gosec linter rule * fix: use crypto/rand number generator
Quality Gate failedFailed conditions |
@joanestebanr It is because of this commit: 3be3e46. Probably not important to deal with it at this point. |
Stefan-Ethernal
added a commit
that referenced
this pull request
Sep 17, 2024
* tests: PoC bridge testing with bats * Run bats in e2e * Remove unused make lines * test: Send EOA and deploy contract E2E tests using Bats (#69) * feat: add helper functions for contract deployment and sending transactions using cast commands * feat: send EOA transaction test basic * feat: deploy ERC20Mock contract E2E test --------- Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
As we progress we need to test many aspects of the system, we already commented that using Go to orchestrate e2e tests is not appropriate so we want to find a way to glue all the tests.
Naturally we've been leaning towards using multiple CLI tools: cast, kurtosis, yq, polycli, k6, etc. and because they can do all, so choosing one tool doesn't make much sense.
So, naturally we've felt back to bash for testing, but bash is not testing friendly, so we need a framework to run tests in bash, enter: Bats, it's a testing framework that uses the standard TAP protocol playing nicely with CI systems.
Description
This is a PoC on how we can use Bats as the testing framework for e2e tests, with a bridging example making use of multiple command line tools and pre-existing bash tests slightly modified to use Bats.
CI will be happy with this.