Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce metrics for BoltDB for the state #1045

Merged
merged 5 commits into from
Dec 13, 2022
Merged

Introduce metrics for BoltDB for the state #1045

merged 5 commits into from
Dec 13, 2022

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Dec 13, 2022 •
edited
Loading

Description

Introduce metrics for BoltDB for the state

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman changed the base branch from develop to feature/v3-parity December 13, 2022 12:33
@begmaroman begmaroman self-assigned this Dec 13, 2022
@begmaroman begmaroman added the feature New update to Polygon Edge label Dec 13, 2022
@begmaroman begmaroman marked this pull request as ready for review December 13, 2022 12:43
vcastellm
vcastellm approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 13, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@ffc8967). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity    #1045   +/-   ##
====================================================
  Coverage                     ?   55.09%           
====================================================
  Files                        ?      168           
  Lines                        ?    22654           
  Branches                     ?        0           
====================================================
  Hits                         ?    12481           
  Misses                       ?     9194           
  Partials                     ?      979

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@begmaroman begmaroman merged commit d0074e6 into feature/v3-parity Dec 13, 2022
@begmaroman begmaroman deleted the feature/EVM-136 branch December 13, 2022 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@ferranbt ferranbt ferranbt approved these changes

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

@igorcrevar igorcrevar Awaiting requested review from igorcrevar

@b00ris b00ris Awaiting requested review from b00ris

@JekaMas JekaMas Awaiting requested review from JekaMas

Assignees

@begmaroman begmaroman

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@begmaroman @vcastellm @ferranbt @Stefan-Ethernal