Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validator set changes #1048

Merged
merged 44 commits into from
Dec 20, 2022

Conversation

0xSasaPrsic
Copy link
Contributor

@0xSasaPrsic 0xSasaPrsic commented Dec 14, 2022

Description

Update proposer priority after validator set changes.
Apply centring and scaling when validator priorities are changed and use initial priority when validator is added.
Dependent on #1018

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@0xSasaPrsic 0xSasaPrsic force-pushed the feature/validator_set_changes branch 2 times, most recently from d8a7e07 to 8eb6b51 Compare December 14, 2022 15:43
@0xSasaPrsic 0xSasaPrsic marked this pull request as ready for review December 14, 2022 15:58
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Merging #1048 (bf8e077) into feature/v3-parity (5f5bcf8) will decrease coverage by 0.04%.
The diff coverage is 74.50%.

@@                  Coverage Diff                  @@
##           feature/v3-parity    #1048      +/-   ##
=====================================================
- Coverage              55.00%   54.95%   -0.05%     
=====================================================
  Files                    171      171              
  Lines                  22922    22951      +29     
=====================================================
+ Hits                   12608    12613       +5     
- Misses                  9326     9346      +20     
- Partials                 988      992       +4     
Impacted Files Coverage Δ
consensus/polybft/proposer_calculator.go 75.30% <74.50%> (-1.80%) ⬇️
network/server_discovery.go 81.36% <0.00%> (-6.84%) ⬇️
network/server.go 74.89% <0.00%> (-0.11%) ⬇️
txpool/txpool.go 73.48% <0.00%> (ø)
consensus/ibft/ibft.go 1.56% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xSasaPrsic 0xSasaPrsic changed the base branch from feature/v3-parity to feature/proposer_calculator_statefull December 15, 2022 09:27
# Conflicts:
#	consensus/polybft/consensus_runtime.go
#	consensus/polybft/consensus_runtime_test.go
#	consensus/polybft/fsm.go
#	consensus/polybft/proposer_calculator.go
#	consensus/polybft/proposer_calculator_test.go
#	consensus/polybft/state.go
#	consensus/polybft/validator_set.go
# Conflicts:
#	consensus/polybft/consensus_runtime.go
#	consensus/polybft/consensus_runtime_test.go
#	consensus/polybft/proposer_calculator.go
#	consensus/polybft/proposer_calculator_test.go
#	consensus/polybft/state.go
#	consensus/polybft/state_test.go
@0xSasaPrsic 0xSasaPrsic changed the base branch from feature/proposer_calculator_statefull to feature/v3-parity December 19, 2022 13:52
@0xSasaPrsic 0xSasaPrsic merged commit cafd3ac into feature/v3-parity Dec 20, 2022
@0xSasaPrsic 0xSasaPrsic deleted the feature/validator_set_changes branch December 20, 2022 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants