Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GossipMessage protobuf #1057

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Dec 18, 2022

Description

Removes GossipMessage protocol buffer as it is not used and TransportMessage is used instead.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal changed the title Remove GossipMessage proto Remove GossipMessage protobuf Dec 18, 2022
@Stefan-Ethernal Stefan-Ethernal self-assigned this Dec 18, 2022
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review December 18, 2022 12:22
@codecov
Copy link

codecov bot commented Dec 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@e993b3b). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity    #1057   +/-   ##
====================================================
  Coverage                     ?   54.93%           
====================================================
  Files                        ?      169           
  Lines                        ?    22768           
  Branches                     ?        0           
====================================================
  Hits                         ?    12507           
  Misses                       ?     9269           
  Partials                     ?      992           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal merged commit c302a6c into feature/v3-parity Dec 19, 2022
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-123-merge-transport-message-and-gossip-message branch December 19, 2022 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants