Fix hash calculation for proposal for go-ibft's update #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorcrevar
reviewed
Dec 23, 2022
igorcrevar
reviewed
Dec 23, 2022
This reverts commit b527ecb.
vcastellm
reviewed
Dec 23, 2022
vcastellm
reviewed
Dec 23, 2022
Kourin1996
changed the title
b00ris
reviewed
Jan 18, 2023
trimixlover
approved these changes
Jan 20, 2023
|
Does it make sense to address these errors before the review process? Error: consensus/ibft/messages.go:27:30: undefined: proto.ProposedBlock
Error: consensus/ibft/messages.go:93:22: undefined: proto.ProposedBlock
Error: consensus/ibft/verifier.go:185:63: undefined: proto.ProposedBlock
Error: consensus/ibft/ibft.go:199:3: cannot use i (variable of type *backendIBFT) as type core.Backend in argument to newIBFT: |
Need a release in go-ibft side because this PR includes a change based on a open PR in go-ibft |
vcastellm
approved these changes
Jan 26, 2023
igorcrevar
approved these changes
Jan 26, 2023
b00ris
approved these changes
Jan 30, 2023
Codecov Report
@@ Coverage Diff @@
## develop #1065 +/- ##
===========================================
+ Coverage 53.85% 54.09% +0.23%
===========================================
Files 132 132
Lines 17596 17704 +108
===========================================
+ Hits 9477 9577 +100
- Misses 7473 7490 +17
+ Partials 646 637 -9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in 0xPolygon/go-ibft#55, hash calculation needs to update for IBFT2.0 consensus.
In particular, IBFT backend must generate hash for IBFT consensus from tuple of
(EthereumBlock, round).This PR changes hash calculation add adds new field for round in IBFT Extra.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it