-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple state sync commitments per epoch #1083
Multiple state sync commitments per epoch #1083
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #1083 +/- ##
====================================================
Coverage ? 54.51%
====================================================
Files ? 173
Lines ? 23033
Branches ? 0
====================================================
Hits ? 12557
Misses ? 9491
Partials ? 985 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
e3243b3
to
02d89b2
Compare
6ad9230
to
57eb5ea
Compare
57eb5ea
to
4bf52d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but leaving a couple of comments to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but leaving a couple of comments to consider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
9087bc8
to
a5b995f
Compare
4deeb56
to
486c05c
Compare
Description
Implemented multiple commitments per epoch feature, as per RFC-178. Wrote appropriate UTs, and a
e2e
test (TestE2E_Bridge_MultipleCommitmentsPerEpoch
).Process of building commitments is as follows:
a. If we have, build a commitment, sign it, and gossip a vote.
b. If we do not have enough state sync events, wait until we have enough.
a. If there is, create a merkle tree, build state sync proofs, and save them to
boltDb
. Also, discard any cached commitment,since a new one will be built in the next block.
b. If there isn’t, wait until some proposer submits the largest commitment with quorum.
Changes include
Checklist
Testing