-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return FullBlock from syncer #1110
Return FullBlock from syncer #1110
Conversation
9569219
to
c998e5f
Compare
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #1110 +/- ##
====================================================
Coverage ? 54.57%
====================================================
Files ? 173
Lines ? 23007
Branches ? 0
====================================================
Hits ? 12557
Misses ? 9465
Partials ? 985 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, only major thing is to remove the functionality from WriteFullBlock
of executing the Block
itself and move that to a custom function (this is, split what WriteBlock
does in two steps).
7128dbb
to
51ac590
Compare
This reverts commit 62166e6.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late LGTM
Description
This PR modifies the
OnBlockInserted
callback toconsensus engine
fromsyncer
so that it returns atypes.FullBlock
(which contains transaction receipts as well, not just the block).This is needed so that the
consensus engine
has all the necessary data forbridge
to properly function, specifically exit workflow, since currently we are only extracting exit events when a block is inserted through consensus.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing