-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E Relayer #1131
Merged
vcastellm
merged 12 commits into
feature/v3-parity
from
EVM-351-add-an-e-2-e-test-for-the-relayer
Jan 20, 2023
Merged
E2E Relayer #1131
vcastellm
merged 12 commits into
feature/v3-parity
from
EVM-351-add-an-e-2-e-test-for-the-relayer
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## feature/v3-parity #1131 +/- ##
=====================================================
+ Coverage 54.59% 54.61% +0.01%
=====================================================
Files 173 173
Lines 23061 23073 +12
=====================================================
+ Hits 12591 12602 +11
- Misses 9480 9483 +3
+ Partials 990 988 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vcastellm
requested review from
Stefan-Ethernal,
goran-ethernal,
Kourin1996,
b00ris,
ferranbt and
Nemanja0x
January 19, 2023 09:33
goran-ethernal
approved these changes
Jan 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Stefan-Ethernal
approved these changes
Jan 19, 2023
Just add description to the PR itself 🙂 |
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
b00ris
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
E2E test for the Relayer, we need to check if StateSyncs are being executed correctly by one of the nodes of the cluster, so we are removing the "manual" execution previously present in e2e test and relay on the Relayer feature to do it as normal operation.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it