Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E Relayer #1131

Merged
merged 12 commits into from
Jan 20, 2023
Merged

Conversation

vcastellm
Copy link
Contributor

@vcastellm vcastellm commented Jan 16, 2023

Description

E2E test for the Relayer, we need to check if StateSyncs are being executed correctly by one of the nodes of the cluster, so we are removing the "manual" execution previously present in e2e test and relay on the Relayer feature to do it as normal operation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #1131 (f383163) into feature/v3-parity (86052c2) will increase coverage by 0.01%.
The diff coverage is 8.69%.

@@                  Coverage Diff                  @@
##           feature/v3-parity    #1131      +/-   ##
=====================================================
+ Coverage              54.59%   54.61%   +0.01%     
=====================================================
  Files                    173      173              
  Lines                  23061    23073      +12     
=====================================================
+ Hits                   12591    12602      +11     
- Misses                  9480     9483       +3     
+ Partials                 990      988       -2     
Impacted Files Coverage Δ
...sus/polybft/statesyncrelayer/state_sync_relayer.go 33.60% <8.69%> (-1.85%) ⬇️
syncer/client.go 61.79% <0.00%> (-1.42%) ⬇️
network/server_discovery.go 81.98% <0.00%> (+7.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vcastellm vcastellm self-assigned this Jan 19, 2023
@vcastellm vcastellm added the bug fix Functionality that fixes a bug label Jan 19, 2023
@vcastellm vcastellm marked this pull request as ready for review January 19, 2023 09:35
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Stefan-Ethernal
Copy link
Collaborator

Just add description to the PR itself 🙂

vcastellm and others added 2 commits January 19, 2023 11:35
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@vcastellm vcastellm merged commit 9244f36 into feature/v3-parity Jan 20, 2023
@vcastellm vcastellm deleted the EVM-351-add-an-e-2-e-test-for-the-relayer branch January 20, 2023 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants