Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude core-contracts from SonarQube checks #1154

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

vcastellm
Copy link
Contributor

Description

We don't want to check core-contracts repo from Edge

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@vcastellm vcastellm self-assigned this Jan 23, 2023
@vcastellm vcastellm added the hotfix Major bug fix that should be merged ASAP label Jan 23, 2023
@vcastellm vcastellm marked this pull request as ready for review January 23, 2023 09:56
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1154 (8aa4370) into develop (6a1db1a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1154      +/-   ##
===========================================
- Coverage    54.27%   54.22%   -0.05%     
===========================================
  Files          132      132              
  Lines        17596    17596              
===========================================
- Hits          9550     9542       -8     
- Misses        7414     7420       +6     
- Partials       632      634       +2     
Impacted Files Coverage Δ
blockchain/subscription.go 76.25% <0.00%> (-6.25%) ⬇️
syncer/client.go 61.79% <0.00%> (-1.42%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcastellm vcastellm merged commit 6fcc824 into develop Jan 23, 2023
@vcastellm vcastellm deleted the exclude-core-contracts-sonarqube branch January 23, 2023 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix Major bug fix that should be merged ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants