Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetNonce function from TxRelayer #1165

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

Remove leftover GetNonce function from TxRelayer as it is dead code.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Jan 25, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (feature/v3-parity@bf5ac4d). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             feature/v3-parity    #1165   +/-   ##
====================================================
  Coverage                     ?   54.49%           
====================================================
  Files                        ?      173           
  Lines                        ?    23179           
  Branches                     ?        0           
====================================================
  Hits                         ?    12632           
  Misses                       ?     9548           
  Partials                     ?      999           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal changed the title Remove GetNonce function from TxRelayer Remove GetNonce function from TxRelayer Jan 26, 2023
@b00ris b00ris merged commit 28f106a into feature/v3-parity Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/remove-txrelayer-get-nonce branch January 26, 2023 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants