-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename uptime to commit epoch #1193
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
fix/rename-uptime-to-commit-epoch
branch
from
February 3, 2023 10:36
fd90516
to
c223234
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1193 +/- ##
===========================================
+ Coverage 54.68% 54.73% +0.04%
===========================================
Files 176 176
Lines 23553 23553
===========================================
+ Hits 12880 12891 +11
+ Misses 9645 9635 -10
+ Partials 1028 1027 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Stefan-Ethernal
requested review from
goran-ethernal,
ferranbt,
vcastellm,
Nemanja0x,
b00ris,
begmaroman,
igorcrevar and
stana-miric
and removed request for
goran-ethernal
February 3, 2023 11:07
Nemanja0x
approved these changes
Feb 3, 2023
goran-ethernal
approved these changes
Feb 3, 2023
Base automatically changed from
EVM-423-TOB-EDGE-19-Validation-of-state-transactions-is-error-prone
to
feature/v3-parity
February 3, 2023 13:20
Stefan-Ethernal
force-pushed
the
fix/rename-uptime-to-commit-epoch
branch
from
February 3, 2023 14:26
c223234
to
812de13
Compare
ferranbt
approved these changes
Feb 3, 2023
Stefan-Ethernal
force-pushed
the
fix/rename-uptime-to-commit-epoch
branch
from
February 6, 2023 06:45
812de13
to
49a6004
Compare
Stefan-Ethernal
force-pushed
the
fix/rename-uptime-to-commit-epoch
branch
from
February 6, 2023 09:37
fa70766
to
3014d71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For the sake of consistency, this PR renames uptime transactions to commit epoch transactions, updates error messages and unit tests accordingly. Logic remained intact.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing