Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename uptime to commit epoch #1193

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Feb 3, 2023

Description

For the sake of consistency, this PR renames uptime transactions to commit epoch transactions, updates error messages and unit tests accordingly. Logic remained intact.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/rename-uptime-to-commit-epoch branch from fd90516 to c223234 Compare February 3, 2023 10:36
@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Merging #1193 (fa70766) into develop (f434a9b) will increase coverage by 0.04%.
The diff coverage is 57.18%.

❗ Current head fa70766 differs from pull request most recent head 3014d71. Consider uploading reports for the commit 3014d71 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1193      +/-   ##
===========================================
+ Coverage    54.68%   54.73%   +0.04%     
===========================================
  Files          176      176              
  Lines        23553    23553              
===========================================
+ Hits         12880    12891      +11     
+ Misses        9645     9635      -10     
+ Partials      1028     1027       -1     
Impacted Files Coverage Δ
archive/restore.go 65.59% <0.00%> (ø)
consensus/ibft/consensus_backend.go 5.17% <0.00%> (ø)
consensus/ibft/fork/helper.go 81.81% <0.00%> (ø)
consensus/ibft/ibft.go 1.45% <0.00%> (ø)
consensus/polybft/block_builder.go 0.00% <0.00%> (ø)
consensus/polybft/contractsapi/helper.go 0.00% <0.00%> (ø)
consensus/polybft/ibft_consensus.go 0.00% <0.00%> (ø)
consensus/polybft/state_stats.go 0.00% <0.00%> (ø)
consensus/polybft/state_sync_manager.go 70.10% <ø> (ø)
consensus/polybft/state_transaction.go 63.63% <ø> (ø)
... and 80 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review February 3, 2023 11:07
@Stefan-Ethernal Stefan-Ethernal self-assigned this Feb 3, 2023
@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Feb 3, 2023
Base automatically changed from EVM-423-TOB-EDGE-19-Validation-of-state-transactions-is-error-prone to feature/v3-parity February 3, 2023 13:20
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/rename-uptime-to-commit-epoch branch from c223234 to 812de13 Compare February 3, 2023 14:26
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/rename-uptime-to-commit-epoch branch from 812de13 to 49a6004 Compare February 6, 2023 06:45
Base automatically changed from feature/v3-parity to develop February 6, 2023 07:53
@Stefan-Ethernal Stefan-Ethernal force-pushed the fix/rename-uptime-to-commit-epoch branch from fa70766 to 3014d71 Compare February 6, 2023 09:37
@Stefan-Ethernal Stefan-Ethernal merged commit cca8611 into develop Feb 6, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/rename-uptime-to-commit-epoch branch February 6, 2023 11:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants