Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetDelegatorReward fix #1194

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

stana-miric
Copy link
Contributor

@stana-miric stana-miric commented Feb 3, 2023

Description

This fix includes changes in GetDelegatorReward fn where getValidatorReward was wrongly called on ChildValidatorSet contract instead of getDelegatorReward. Also, it includes modifications in TestE2E_Consensus_Delegation_Undelegation where proper key (delegator's) is now used for sending delegate, undelegate and withdraw requests and some minor test improvements.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Feb 3, 2023
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Base automatically changed from feature/v3-parity to develop February 6, 2023 07:53
@stana-miric stana-miric force-pushed the EVM-379-investigate-undelegation-workflow branch from 82a4b88 to 7a53d4e Compare February 6, 2023 08:13
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1194 (7a53d4e) into develop (f434a9b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1194   +/-   ##
========================================
  Coverage    54.68%   54.68%           
========================================
  Files          176      176           
  Lines        23553    23553           
========================================
  Hits         12880    12880           
  Misses        9645     9645           
  Partials      1028     1028           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stana-miric stana-miric merged commit 55a9e0c into develop Feb 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2023
@vcastellm vcastellm deleted the EVM-379-investigate-undelegation-workflow branch February 6, 2023 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants