Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract SC integration tests to a separate file #1203

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Feb 6, 2023

Description

This PR extracts SC integration tests to a separate file, to be able to easier maintain the test codebase in the future. Affected tests are between unit tests and e2e tests, as they test SC integration points. Therefore decided to call them integration tests (prefix TestIntegration).

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Feb 6, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Feb 6, 2023
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #1203 (8b14116) into develop (cca8611) will not change coverage.
The diff coverage is n/a.

❗ Current head 8b14116 differs from pull request most recent head 7058843. Consider uploading reports for the commit 7058843 to get more accurate results

@@           Coverage Diff            @@
##           develop    #1203   +/-   ##
========================================
  Coverage    54.68%   54.68%           
========================================
  Files          176      176           
  Lines        23553    23553           
========================================
  Hits         12880    12880           
  Misses        9645     9645           
  Partials      1028     1028           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Base automatically changed from fix/rename-uptime-to-commit-epoch to develop February 6, 2023 11:06
@Stefan-Ethernal Stefan-Ethernal merged commit fa801fb into develop Feb 7, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the fix/extract-sc-integration-tests branch February 7, 2023 12:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants