Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate validator set delta content #1215

Merged
merged 2 commits into from
Feb 13, 2023
Merged

Validate validator set delta content #1215

merged 2 commits into from
Feb 13, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Feb 10, 2023 •
edited
Loading

Description

This PR implements validation of ValidatorSetDelta from Extra data. It basically consists of checking equality between the delta calculated by the validator and the one provided by the proposer.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the feature New update to Polygon Edge label Feb 10, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Feb 10, 2023
@Stefan-Ethernal Stefan-Ethernal changed the base branch from develop to EVM-403-move-signatures-verification-logic-to-extra February 10, 2023 12:49
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review February 10, 2023 12:50
goran-ethernal
goran-ethernal approved these changes Feb 10, 2023
View reviewed changes
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

Base automatically changed from EVM-403-move-signatures-verification-logic-to-extra to develop February 13, 2023 08:33
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-402-validate-validator-set-delta-content branch from 83d257f to 9aa7e47 Compare February 13, 2023 08:35
@Stefan-Ethernal Stefan-Ethernal merged commit f917a74 into develop Feb 13, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-402-validate-validator-set-delta-content branch February 13, 2023 12:12
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@begmaroman begmaroman begmaroman approved these changes

@b00ris b00ris b00ris approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@ferranbt ferranbt Awaiting requested review from ferranbt

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
feature New update to Polygon Edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Stefan-Ethernal @igorcrevar @b00ris @begmaroman @Nemanja0x @goran-ethernal