-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets manager introduced to commands #1251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good.
Points to consider addressing:
- What should we do with
command/rootchain/emit/emit.go
andcommand/rootchain/initcontracts/init_contracts.go
? Those two commands are expecting hex-encoded private key to be provided via the CLI flag, but not sure if is it ok to leave it like that. - Also just mark
DataPathFlag
andConfigFlag
mutually exclusive in each command it accommodates it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Late review but shared flags between subcommands can be defined in the top level command if I'm not wrong.
Description
Commands stake, unstake, withdraw, validator info use secret manager to provide access to cloud secret storage or local disc.
Naming of the flags are standardized for all commands:
DataPathFlag = "data-dir" - for local storage
ConfigFlag = "config" - cloud config
Changes include
Checklist
Testing
Manual tests