Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove smart contracts path flags #1254

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Remove smart contracts path flags #1254

merged 2 commits into from
Feb 28, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Feb 27, 2023 •
edited
Loading

Description

Since Edge is using embedded smart contracts definition, there is no need to specify smart contract root directory via CLI commands. This PR removes deprecated flags and make compile-core-contracts step when executing polybft e2e tests.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Feb 27, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Feb 27, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-491-remove-smart-contracts-path-from-commands branch from c61cb95 to 71042ef Compare February 27, 2023 09:27
@Stefan-Ethernal Stefan-Ethernal mentioned this pull request Feb 27, 2023
Merged
11 tasks
vcastellm
vcastellm approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 🧹

@Stefan-Ethernal Stefan-Ethernal merged commit eccbae3 into develop Feb 28, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-491-remove-smart-contracts-path-from-commands branch February 28, 2023 08:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Nemanja0x Nemanja0x Nemanja0x approved these changes

@b00ris b00ris b00ris approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

@begmaroman begmaroman Awaiting requested review from begmaroman

@stana-miric stana-miric Awaiting requested review from stana-miric

Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Stefan-Ethernal @vcastellm @igorcrevar @b00ris @Nemanja0x @goran-ethernal