Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Send approve transaction on each deposit #1288

Merged

Conversation

Stefan-Ethernal
Copy link
Collaborator

Description

This PR fixes sending approval transactions for RootERC20Predicate. Prior to this, it was sent only by the root chain contracts deployer, which allowed RootERC20Predicate to spend ERC20 tokens only on its behalf. Now approval transaction is being sent before each deposit, which is correct behavior, allowing arbitrary account to send deposit transaction and not only the root chain contracts deployer.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Mar 10, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team March 10, 2023 20:23
@Stefan-Ethernal Stefan-Ethernal self-assigned this Mar 10, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-514-bridge-do-erc-20-approvals-on-each-deposit branch from a9f269c to e3e323e Compare March 14, 2023 05:44
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-514-bridge-do-erc-20-approvals-on-each-deposit branch from e3e323e to 1b1c3c2 Compare March 14, 2023 07:04
@Stefan-Ethernal Stefan-Ethernal merged commit 6fcaa2e into develop Mar 14, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-514-bridge-do-erc-20-approvals-on-each-deposit branch March 14, 2023 12:53
@github-actions github-actions bot locked and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants