-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shorten execution time of E2E tests #1360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
changed the title
Provide epoch size to consensus tests
Shorten execution time of E2E tests
Apr 5, 2023
Stefan-Ethernal
force-pushed
the
EVM-548-shorten-e2e-execution-time
branch
from
April 6, 2023 21:58
e24685a
to
86027f9
Compare
Stefan-Ethernal
requested review from
a team,
vcastellm,
igorcrevar,
Nemanja0x,
stana-miric and
goran-ethernal
April 9, 2023 12:26
stana-miric
approved these changes
Apr 10, 2023
Nemanja0x
approved these changes
Apr 10, 2023
goran-ethernal
approved these changes
Apr 10, 2023
…ents into single test
Stefan-Ethernal
force-pushed
the
EVM-548-shorten-e2e-execution-time
branch
from
April 10, 2023 10:27
a2f764c
to
149f738
Compare
igorcrevar
reviewed
Apr 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changelog:
TestE2E_Consensus_Sync_WithNonValidators
, until we implement proper support for non-validator nodes in E2E framework.helpers_test.go
.waitForRootchainEpoch
helper function, which checks whether target epoch is reached.TestE2E_Bridge_DepositAndWithdrawERC20
andTestE2E_Bridge_MultipleCommitmentsPerEpoch
intoTestE2E_Bridge_Transfers
test (resulted in ~2 mins faster execution).TestE2E_Consensus_Basic_WithNonValidators
andTestE2E_Consensus_Sync
intoTestE2E_Consensus_Basic_WithNonValidators
(resulted in ~7 secs faster execution).Changes include
Checklist
Testing