Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional header validations #1508

Merged
merged 4 commits into from
May 15, 2023
Merged

Additional header validations #1508

merged 4 commits into from
May 15, 2023

Conversation

Nemanja0x
Copy link
Contributor

@Nemanja0x Nemanja0x commented May 15, 2023

Description

The PR add more validations for header in validationHeaderFields.

Check header ExtraData length. If length is less than 32 bytes return error.
Check header Nonce equals to zero, if not return error.
Check header GasUsed less than headers GasiLimit, if exceed return error.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Nemanja0x Nemanja0x self-assigned this May 15, 2023
@Nemanja0x Nemanja0x added the feature New update to Polygon Edge label May 15, 2023
Co-authored-by: Stefan Negovanović <93934272+Stefan-Ethernal@users.noreply.github.com>
@Nemanja0x Nemanja0x marked this pull request as ready for review May 15, 2023 13:25
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

types/header.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@goran-ethernal goran-ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but maybe consider adding couple of UTs that test these negative paths.

@Nemanja0x
Copy link
Contributor Author

LGTM, but maybe consider adding couple of UTs that test these negative paths.

fixed: 76b225e

@Nemanja0x Nemanja0x merged commit 56eea51 into develop May 15, 2023
@Nemanja0x Nemanja0x deleted the evm-598 branch May 15, 2023 17:42
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
@Nemanja0x Nemanja0x restored the evm-598 branch May 15, 2023 17:43
@Nemanja0x Nemanja0x deleted the evm-598 branch May 15, 2023 18:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants