-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Revert result as Data #1566
Merged
vcastellm
merged 9 commits into
develop
from
EVM-602-custom-solidity-errors-introduced-in-0-8-4-not-supported
Jun 2, 2023
Merged
Return Revert result as Data #1566
vcastellm
merged 9 commits into
develop
from
EVM-602-custom-solidity-errors-introduced-in-0-8-4-not-supported
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows returning custom revert errors from solidity, they are ABI encoded functions that can represent rich and gas efficient revert messages.
igorcrevar
reviewed
Jun 1, 2023
Stefan-Ethernal
approved these changes
Jun 1, 2023
goran-ethernal
approved these changes
Jun 1, 2023
igorcrevar
approved these changes
Jun 1, 2023
vcastellm
deleted the
EVM-602-custom-solidity-errors-introduced-in-0-8-4-not-supported
branch
June 2, 2023 09:22
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows returning custom revert errors from solidity, they are ABI encoded functions that can represent rich and gas efficient revert messages.
Details of custom errors: https://blog.soliditylang.org/2021/04/21/custom-errors/
This is the implementation expected by ethers.js and web3.js and the format go-ethereum chose ethereum/go-ethereum#19027 (comment)
This PR implements it following this format.
Fixes #1350
Changes include
Checklist
Testing