Invoke estimate gas limit if gas limit not already provided #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ransactions # Conflicts: # txrelayer/txrelayer.go
Stefan-Ethernal
force-pushed
the
EVM-676-estimate-gas-limit-when-sending-transactions
branch
from
a0612f4
to
ac2ad4b
Compare
goran-ethernal
approved these changes
Jun 19, 2023
…ransactions # Conflicts: # txrelayer/txrelayer.go
jelacamarko
deleted the
EVM-676-estimate-gas-limit-when-sending-transactions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transaction relayer (aka
TxRelayer) relies oneth_estimateGasLimitto calculate the gas limit and set it to the transaction, instead of using the hardcoded value before sending the transaction.Hardcoded gas limit values are left only in the
bridge exitCLI command and inside E2E test framework as a fallback in case gas estimation fails (for example account is not allow listed).Changes include
Checklist
Testing