Ensure that the same child token addresses are calculated on both chains #1621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures that the same child token addresses are calculated on both sides of the bridge (root and child predicates). This is accomplished by providing the same child token template addresses to both root and child predicates.
Also, bridge E2E tests now contain explicit checks of child token addresses being the same calculated on both sides of the bridge.
Before this PR, different child token addresses were provided to root and child predicates, resulting in different calculations of child token addresses.
Changes include
Breaking changes
Child token template addresses from the root chain are persisted in the
genesis.json
.Checklist
Testing