Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM-697]: Implement eth_maxPriorityFeePerGas #1629

Merged
merged 8 commits into from
Jun 21, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jun 16, 2023

Description

This PR implements eth_maxPriorityFeePerGas json rpc endpoint.

Parameters:

  • This method does not accept any parameters.

Returns:

  • result string - The hex value of the priority fee needed to be included in a block (in wei).

Request:

curl https://link-to-some-node/ \
-X POST \
-H "Content-Type: application/json" \
--data '{"method":"eth_maxPriorityFeePerGas","params":[],"id":1,"jsonrpc":"2.0"}'

Response:

{
  "jsonrpc": "2.0",
  "id": 1,
  "result": "0xbebc200"
 }

The eth_maxPriorityFeePerGas rpc point returns an estimated fee per gas, indicating the amount you can pay as a priority fee (tip) in order to have a transaction in the current block.

Edge implementation follows the go-ethereum implementation.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal self-assigned this Jun 16, 2023
@goran-ethernal goran-ethernal added the feature New update to Polygon Edge label Jun 16, 2023
@goran-ethernal goran-ethernal force-pushed the EVM-697-Implement-eth_maxPriorityFee branch 5 times, most recently from bc16602 to e6479e3 Compare June 16, 2023 13:59
@goran-ethernal goran-ethernal requested a review from a team June 16, 2023 14:08
@goran-ethernal goran-ethernal marked this pull request as ready for review June 16, 2023 14:08
@goran-ethernal goran-ethernal force-pushed the EVM-697-Implement-eth_maxPriorityFee branch from 58c2de5 to 6ceee16 Compare June 19, 2023 07:05
gasprice/gasprice.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
gasprice/gasprice.go Show resolved Hide resolved
gasprice/gasprice.go Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
gasprice/gasprice.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal force-pushed the EVM-697-Implement-eth_maxPriorityFee branch from 74c482e to 67ff422 Compare June 21, 2023 07:18
@goran-ethernal goran-ethernal changed the title [EVM-697]: Implement eth_maxPriorityFee [EVM-697]: Implement eth_maxPriorityFeePerGas Jun 21, 2023
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goran-ethernal goran-ethernal merged commit d98b3e5 into develop Jun 21, 2023
@goran-ethernal goran-ethernal deleted the EVM-697-Implement-eth_maxPriorityFee branch June 21, 2023 08:57
@github-actions github-actions bot locked and limited conversation to collaborators Jun 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New update to Polygon Edge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants