Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM-728 Gas price comparison for executable transactions in pricedQueue #1696

Merged
merged 5 commits into from
Jul 11, 2023
Merged

EVM-728 Gas price comparison for executable transactions in pricedQueue #1696

merged 5 commits into from
Jul 11, 2023

Conversation

igorcrevar
Copy link
Contributor

Description

Gas price comparison (for executable transactions in pricedQueue) does not take GasPrice for legacy transactions. Consequence is that those are not pulled in order when block builder builds block

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@igorcrevar igorcrevar added the bug fix Functionality that fixes a bug label Jul 4, 2023
@igorcrevar igorcrevar requested a review from a team July 4, 2023 11:29
@igorcrevar igorcrevar self-assigned this Jul 4, 2023
@igorcrevar igorcrevar force-pushed the feature/EVM-728_gas_price_comparison branch 4 times, most recently from 74465d1 to 3b9b3a6 Compare July 4, 2023 16:01
@igorcrevar igorcrevar marked this pull request as ready for review July 5, 2023 09:08
@igorcrevar igorcrevar force-pushed the feature/EVM-728_gas_price_comparison branch from 3b9b3a6 to 547d3a4 Compare July 7, 2023 13:18
vcastellm
vcastellm reviewed Jul 10, 2023
View reviewed changes
txpool/queue_priced.go Outdated Show resolved Hide resolved
goran-ethernal
goran-ethernal reviewed Jul 10, 2023
View reviewed changes
txpool/txpool.go Outdated Show resolved Hide resolved
@igorcrevar igorcrevar merged commit f4efe97 into develop Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the feature/EVM-728_gas_price_comparison branch August 1, 2023 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@begmaroman begmaroman begmaroman approved these changes

@vcastellm vcastellm vcastellm approved these changes

@Nemanja0x Nemanja0x Awaiting requested review from Nemanja0x

@Stefan-Ethernal Stefan-Ethernal Awaiting requested review from Stefan-Ethernal

@stana-miric stana-miric Awaiting requested review from stana-miric

Assignees

@igorcrevar igorcrevar

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igorcrevar @vcastellm @begmaroman @goran-ethernal