This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
Eip 2929 #1748
Merged
Eip 2929 #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachit77
added
don't merge
| @@ -437,6 +437,7 @@ func TestCreate(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // EIP2929: check some test return error when triggered from base | |||
There was a problem hiding this comment.
Could you add some unit tests that would test different gas consumptions per opcodes? I see that you have opted to test it out on a higher level of abstraction (namely on the EVM level), but I think it would be beneficial for us to have some "atomic" unit tests (namely the ones that would test gas consumption per specific op code, depending on which hard fork is enabled).
WDYT?
There was a problem hiding this comment.
yeah that makes sense to me, I will add those unit test.
For these EVM level transactions I have also verified the cost of individual opcodes by printing call stack.
There was a problem hiding this comment.
added uint test cases for some opcodes and will add more with eip-2930 implementation
rachit77
requested review from
Stefan-Ethernal and
goran-ethernal
and removed request for
vcastellm
begmaroman
approved these changes
Aug 17, 2023
igorcrevar
approved these changes
Aug 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EIP-2929 implementation for Edge
Reference: https://eips.ethereum.org/EIPS/eip-2929
Changes include
Checklist
Testing
Manual tests
Manually verified the call stack for tests included