Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC-191]: EVM-750 - Governance e2e tests #1761

Merged
merged 2 commits into from
Aug 7, 2023
Merged

[RFC-191]: EVM-750 - Governance e2e tests #1761

merged 2 commits into from
Aug 7, 2023

Conversation

goran-ethernal
Copy link
Collaborator

@goran-ethernal goran-ethernal commented Jul 28, 2023 •
edited
Loading

Description

This PR implements e2e tests for on-chain governance.

Tests are:

  • proposing a new epoch size, voting for proposal, and executing it.
  • proposing a new sprint size, but the proposal doesn't have quorum to be accepted.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@goran-ethernal goran-ethernal force-pushed the EVM-750-Governance-e2e-tests branch 2 times, most recently from 4ff2216 to 8b0b6a7 Compare July 28, 2023 10:12
@goran-ethernal goran-ethernal marked this pull request as ready for review July 28, 2023 11:24
@goran-ethernal goran-ethernal self-assigned this Jul 28, 2023
@goran-ethernal goran-ethernal requested a review from a team July 28, 2023 11:25
Base automatically changed from EVM-558-Read-parameters-from-NetworkParams-contract to feat/on-chain-governance July 31, 2023 13:43
Stefan-Ethernal
Stefan-Ethernal approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, but leaving a couple of notes to eventually consider.

e2e-polybft/e2e/governance_test.go Show resolved Hide resolved
command/genesis/polybft_params.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/governance_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/governance_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/governance_test.go Outdated Show resolved Hide resolved
e2e-polybft/e2e/governance_test.go Outdated Show resolved Hide resolved
@goran-ethernal goran-ethernal force-pushed the EVM-750-Governance-e2e-tests branch 2 times, most recently from 17e77af to 99a04c7 Compare August 1, 2023 07:33
@goran-ethernal goran-ethernal merged commit c9794bf into feat/on-chain-governance Aug 7, 2023
7 checks passed
@goran-ethernal goran-ethernal deleted the EVM-750-Governance-e2e-tests branch August 7, 2023 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dusan-maksimovic dusan-maksimovic dusan-maksimovic approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@goran-ethernal goran-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goran-ethernal @Stefan-Ethernal @dusan-maksimovic