-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root chain proxy contracts deployment #1888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusan-maksimovic
added
the
breaking change
Functionality that contains breaking changes
label
Sep 7, 2023
goran-ethernal
approved these changes
Sep 8, 2023
Nemanja0x
approved these changes
Sep 11, 2023
Should we premine/fund rootchain proxy contract admin in cluster script (and other deployment scripts that are maintained by dev tools team)? |
Stefan-Ethernal
approved these changes
Sep 11, 2023
dusan-maksimovic
force-pushed
the
rootchain-proxies
branch
from
September 11, 2023 12:51
f0b7ce1
to
18372dc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deploys proxy contract on the root chain, for all our contracts except token templates and StateSender contract. StateSender is not intended to be upgradeable (info from the SCs team), so it is not proxified.
Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing