Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root chain proxy contracts deployment #1888

Merged
merged 5 commits into from
Sep 11, 2023
Merged

Conversation

dusan-maksimovic
Copy link
Contributor

Description

This PR deploys proxy contract on the root chain, for all our contracts except token templates and StateSender contract. StateSender is not intended to be upgradeable (info from the SCs team), so it is not proxified.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusan-maksimovic dusan-maksimovic added the breaking change Functionality that contains breaking changes label Sep 7, 2023
@dusan-maksimovic dusan-maksimovic requested a review from a team September 7, 2023 12:59
@dusan-maksimovic dusan-maksimovic self-assigned this Sep 7, 2023
command/helper/helper.go Outdated Show resolved Hide resolved
command/rootchain/deploy/deploy.go Outdated Show resolved Hide resolved
@Stefan-Ethernal
Copy link
Collaborator

Stefan-Ethernal commented Sep 11, 2023

Should we premine/fund rootchain proxy contract admin in cluster script (and other deployment scripts that are maintained by dev tools team)?

command/rootchain/supernet/stakemanager/params.go Outdated Show resolved Hide resolved
command/rootchain/deploy/params.go Outdated Show resolved Hide resolved
command/rootchain/deploy/deploy.go Show resolved Hide resolved
@dusan-maksimovic dusan-maksimovic merged commit c49733b into develop Sep 11, 2023
6 of 7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
@dusan-maksimovic dusan-maksimovic deleted the rootchain-proxies branch September 11, 2023 14:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants