Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stake token address as mandatory in certain use cases #1914

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Sep 18, 2023

Description

Make stake-token flag mandatory in the stake-manager-deploy and the rootchain fund commands in case no test is used for stake-manager-deploy and in case stake tokens need to be minted in the rootchain fund command.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@Stefan-Ethernal Stefan-Ethernal added the bug fix Functionality that fixes a bug label Sep 18, 2023
@Stefan-Ethernal Stefan-Ethernal self-assigned this Sep 18, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Stake token address is mandatory in non-test mode Make stake token address as mandatory in certain use cases Sep 18, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team September 18, 2023 13:59
@Stefan-Ethernal Stefan-Ethernal merged commit 4fbe4ba into develop Sep 19, 2023
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2023
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-836-make-stake-token-address-mandatory branch September 19, 2023 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fix Functionality that fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants