Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer and Validator node types are represented as enum flags in E2E framework #1962

Merged
merged 3 commits into from
Oct 9, 2023

Conversation

jelacamarko
Copy link
Contributor

@jelacamarko jelacamarko commented Oct 5, 2023

Description

In e2e test framework, InitTestServer method now has a flags field instead of isValidator, relayer fields.
flags field represents enum flags.
If we want to init server as validator and relayer, we can pass Validator | Relayer as value for flags.
HasFlag function is used to check if the flag is present in flags.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@jelacamarko jelacamarko requested a review from a team October 5, 2023 11:40
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I've put a couple of minor suggestions.

e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
e2e-polybft/framework/test-cluster.go Outdated Show resolved Hide resolved
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 5, 2023 12:00
@Stefan-Ethernal Stefan-Ethernal changed the title Relayer and isValidator are represented as enum flags Relayer and Validator node types are represented as enum flags in E2E framework Oct 6, 2023
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 6, 2023 06:57
@jelacamarko jelacamarko merged commit 5e11256 into develop Oct 9, 2023
10 checks passed
@jelacamarko jelacamarko deleted the evm-781 branch October 9, 2023 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants