Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Update web3_clientVersion endpoint to return a correct value #1965

Merged
merged 10 commits into from
Oct 9, 2023
Merged

Update web3_clientVersion endpoint to return a correct value #1965

merged 10 commits into from
Oct 9, 2023

Conversation

begmaroman
Copy link
Contributor

@begmaroman begmaroman commented Oct 6, 2023 •
edited
Loading

Description

Update the given endpoint in order to return a correct value as defined per https://ethereum.org/en/developers/docs/apis/json-rpc/#web3_clientversion

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@begmaroman begmaroman self-assigned this Oct 6, 2023
@begmaroman begmaroman marked this pull request as ready for review October 6, 2023 08:55
@begmaroman begmaroman added the bug fix Functionality that fixes a bug label Oct 6, 2023
vcastellm
vcastellm approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Stefan-Ethernal
Stefan-Ethernal reviewed Oct 6, 2023
View reviewed changes
jsonrpc/web3_endpoint.go Outdated Show resolved Hide resolved
jsonrpc/web3_endpoint_test.go Outdated Show resolved Hide resolved
@begmaroman begmaroman merged commit bbb52d5 into develop Oct 9, 2023
9 checks passed
@begmaroman begmaroman deleted the feature/EVM-364 branch October 9, 2023 11:40
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

@rachit77 rachit77 rachit77 approved these changes

@igorcrevar igorcrevar igorcrevar approved these changes

@vcastellm vcastellm vcastellm approved these changes

@goran-ethernal goran-ethernal Awaiting requested review from goran-ethernal

Assignees

@begmaroman begmaroman

Labels
bug fix Functionality that fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@begmaroman @vcastellm @igorcrevar @rachit77 @Stefan-Ethernal