Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract BLS library used in polybft to a standalone package #1981

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

Stefan-Ethernal
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal commented Oct 11, 2023

Description

This PR extracts bls signing abstractions already used for polybft consensus protocol, which relies on this library https://github.com/umbracle/go-eth-bn256 to Edge standalone package.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-861-remove-kriptology-dependency branch from 4477516 to 3910247 Compare October 13, 2023 15:44
@Stefan-Ethernal Stefan-Ethernal added the breaking change Functionality that contains breaking changes label Oct 15, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove kryptology library Remove kryptology library for BLS keys Oct 15, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove kryptology library for BLS keys Remove kryptology library that handles BLS curves Oct 15, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove kryptology library that handles BLS curves Remove kryptology library that handles BLS curves Oct 15, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-861-remove-kriptology-dependency branch 3 times, most recently from 33312d3 to 284a9e3 Compare October 16, 2023 18:36
@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 16, 2023 20:06
@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review October 16, 2023 20:06
@Stefan-Ethernal Stefan-Ethernal self-assigned this Oct 17, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove kryptology library that handles BLS curves Remove kryptology library for BLS signing Oct 17, 2023
Copy link
Contributor

@igorcrevar igorcrevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small remark, otherwise good

@vcastellm
Copy link
Contributor

If this is not IBFT backwards compatible maybe IBFT can be removed at this point?

@Stefan-Ethernal
Copy link
Collaborator Author

If this is not IBFT backwards compatible maybe IBFT can be removed at this point?

We can discuss it and decide, I was thinking the same.

However, I'd still prefer to have this PR merged (first), because:

  • I find it useful to extract the bls package to a separate one, outside of the polybft, because it should not be tied with any specific consensus protocol,
  • removing IBFT entirely represents a larger effort.

Does it make sense?

@Stefan-Ethernal Stefan-Ethernal requested a review from a team October 17, 2023 11:34
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-861-remove-kriptology-dependency branch 2 times, most recently from 98fca7d to 52365b9 Compare October 18, 2023 06:28
@Stefan-Ethernal Stefan-Ethernal added the don't merge Please don't merge this functionality temporarily label Oct 18, 2023
@Stefan-Ethernal Stefan-Ethernal changed the title Remove kryptology library for BLS signing Extract BLS library used in polybft to a standalone package Oct 26, 2023
@Stefan-Ethernal Stefan-Ethernal force-pushed the EVM-861-remove-kriptology-dependency branch from 52365b9 to d1baa1d Compare October 26, 2023 10:10
@Stefan-Ethernal Stefan-Ethernal merged commit 34e08f1 into develop Oct 31, 2023
6 of 7 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the EVM-861-remove-kriptology-dependency branch October 31, 2023 07:28
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change Functionality that contains breaking changes don't merge Please don't merge this functionality temporarily
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants