-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract BLS library used in polybft to a standalone package #1981
Extract BLS library used in polybft to a standalone package #1981
Conversation
4477516
to
3910247
Compare
kryptology
library that handles BLS curves
33312d3
to
284a9e3
Compare
kryptology
library that handles BLS curveskryptology
library for BLS signing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small remark, otherwise good
If this is not IBFT backwards compatible maybe IBFT can be removed at this point? |
We can discuss it and decide, I was thinking the same. However, I'd still prefer to have this PR merged (first), because:
Does it make sense? |
98fca7d
to
52365b9
Compare
kryptology
library for BLS signing52365b9
to
d1baa1d
Compare
Description
This PR extracts bls signing abstractions already used for
polybft
consensus protocol, which relies on this library https://github.com/umbracle/go-eth-bn256 to Edge standalone package.Changes include
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing
Manual tests
Please complete this section if you ran manual tests for this functionality, otherwise delete it
Documentation update
Please link the documentation update PR in this section if it's present, otherwise delete it
Additional comments
Please post additional comments in this section if you have them, otherwise delete it