Do not send checkpoint if node is syncing #1982
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user of Edge had an issue where he was testing Disaster Recovery simulation, where he stopped a validator node, and deleted all its data, to see if the node will sync up, recover, and rejoin consensus.
He noticed that while syncing, node was trying to send checkpoints on epoch ending blocks where he was a minter before it was shutdown and its data got deleted.
Since those checkpoints were already sent to
rootchain
, this PR introduces a fix, where onsubmitCheckpoint
, it checks if given checkpoint was already sent, and simply returns if it is.Changes include
Checklist
Testing